fix(core): fix page redirects comparison #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous code double encode the |
Pull Request Test Coverage Report for Build 9154210680Details
💛 - Coveralls |
meteorlxy
reviewed
May 20, 2024
|
|
||
| // add redirect to the set when the redirect could not be normalized & encoded to the page path | ||
| if (normalizedPathInferred !== path && encodedPathInferred !== path) { | ||
| redirectsSet.add(encodedPathInferred) |
There was a problem hiding this comment.
Maybe we don't need the set anymore? After several iterations, there's only one possible redirect here?
There was a problem hiding this comment.
I think we should still compare the both because users might set a /中文.html manually. And this extra compare would not take much time.
meteorlxy
changed the title
meteorlxy
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.