Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundler-webpack): replace webpack-chain with webpack-5-chain (close #1503) #1566

Merged
merged 5 commits into from
May 22, 2024
Merged

feat(bundler-webpack): replace webpack-chain with webpack-5-chain (close #1503) #1566

merged 5 commits into from
May 22, 2024

Conversation

Mister-Hope
Copy link
Member

No description provided.

@Mister-Hope Mister-Hope linked an issue May 21, 2024 that may be closed by this pull request
[Bug report] Replace webpack-chain with webpack-5-chain #1503
Closed
@Mister-Hope Mister-Hope changed the title feat(bundler-webpack): use webpack-5-chain instead of webpack-chain feat(bundler-webpack): use webpack-5-chain instead of webpack-chain, close #1503 May 21, 2024
@coveralls
Copy link

coveralls commented May 21, 2024 •
edited

Pull Request Test Coverage Report for Build 9184187224

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.16%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/bundler-webpack/src/build/createClientConfig.ts 0 1 0.0%
packages/bundler-webpack/src/config/handleDevtool.ts 0 1 0.0%
packages/bundler-webpack/src/config/handleOtherOptions.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 9184115522: 0.0%
Covered Lines: 688
Relevant Lines: 1709
💛 - Coveralls

meteorlxy
meteorlxy reviewed May 22, 2024
View reviewed changes
packages/bundler-webpack/src/build/createClientConfig.ts Outdated
}),
config.optimization.minimizer('css').use(CssMinimizerPlugin, [
{
minify:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would remove the default minimizer.

@meteorlxy meteorlxy changed the title feat(bundler-webpack): use webpack-5-chain instead of webpack-chain, close #1503 feat(bundler-webpack): replace webpack-chain with webpack-5-chain (close #1503) May 22, 2024
@meteorlxy meteorlxy merged commit 21ae915 into main May 22, 2024
30 checks passed
@meteorlxy meteorlxy deleted the webpack-chain branch May 22, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy meteorlxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug report] Replace webpack-chain with webpack-5-chain
3 participants
@Mister-Hope @coveralls @meteorlxy