Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Nav Landmark Needs Unique Role/Title/Label #21

Closed
nruffing opened this issue Jan 15, 2024 · 0 comments · Fixed by #23
Closed

[Bug report] Nav Landmark Needs Unique Role/Title/Label #21

nruffing opened this issue Jan 15, 2024 · 0 comments · Fixed by #23
Assignees
@nruffing
Labels
enhancement New feature or request package:theme-default

Comments

@nruffing
Copy link
Contributor

nruffing commented Jan 15, 2024 •
edited

Description

Dequeue recommends all HTML landmarks have a unique role, title or aria-label. If the page is using the auto link page nav there are two nav elements on the page with the same landmark role.
https://dequeuniversity.com/rules/axe/4.8/landmark-unique?application=AxeChrome

Reproduction

NA

Used Package Manager

npm

System Info

NA
@nruffing nruffing added bug Something isn't working package:theme-default labels Jan 15, 2024
@nruffing nruffing self-assigned this Jan 15, 2024
nruffing added a commit to nruffing/vuepress-ecosystem that referenced this issue Jan 21, 2024
@nruffing
feat(theme-default): add labels to differ nav landmarks (close vuepre…
a68600f 
…ss#21)
@nruffing nruffing mentioned this issue Jan 21, 2024
Merged
5 tasks
@Mister-Hope Mister-Hope added enhancement New feature or request and removed bug Something isn't working labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nruffing nruffing

Labels
enhancement New feature or request package:theme-default
Projects
None yet
Milestone
No milestone
2 participants
@nruffing @Mister-Hope