-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init watermark plugin #111
Conversation
I think the docs should be detailed telling defineWatermarkConfig can used to add hooks to watermark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need some tweaks in shared folder, make sure they should be used at both side.
For example the plugin option containing pageFilter is a node side one, then it should be node/options.ts
This ensures that these kind of types can not be imported in wrong side.
LGTM, I leave a comment at a check of image, check that, maybe you want to mean or? |
Pull Request Test Coverage Report for Build 8969158557Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, I will make some tweaks later
Currently this PR is blocked by the latest commit at main. I am still figuring out that. |
BTW, could you add some e2e tests? |
When I run |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix e2e tests plz
Done |
@pengzhanbo Hi, I rebuild the plugin, and you are welcomed to review this for me. The rebuild is containing:
|
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
Integrate watermark-js-plus into VuePress。
This plugin can add watermark to the pages, you can choose between add watermark globally or on specific pages. You can also choose between add text watermark or image watermark.