Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

fix: update dayjs call #93

Closed
wants to merge 1 commit into from
Closed

fix: update dayjs call #93

wants to merge 1 commit into from

Conversation

adajoy
Copy link

@adajoy adajoy commented Jan 4, 2021

add ".default" to avoid error "dayjs is not a function".

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

add ".default" to avoid error "dayjs is not a function".
@jbartkowiak
Copy link

Hey @adajoy, thanks for fixing this! Just stumbled upon this and began wasting time on it ;-)

@billyyyyy3320
Copy link
Member

billyyyyy3320 commented Jan 16, 2021

Thanks for your PR.

I found it's an issue from dayjs and webpack which they have already handled it.

webpack/webpack#4742
iamkun/dayjs#480
iamkun/dayjs#492

@billyyyyy3320
Copy link
Member

billyyyyy3320 commented Jan 16, 2021

Closed by #94

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants