This repository has been archived by the owner on May 13, 2024. It is now read-only.
fix: fonts are inaccessible (fix #40) #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you for the fix 😄 However when I use webpack (outside Vuepress) I don't have to copy fonts files since I use |
|
Thanks for info. I'll check out VP's source code.👍 |
billyyyyy3320
added a commit
that referenced
this pull request
Jan 13, 2020
billyyyyy3320
added a commit
that referenced
this pull request
Jan 13, 2020
billyyyyy3320
added a commit
that referenced
this pull request
Jan 13, 2020
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)Other information:
Currently, there seems to be no api for passing files to the output directory. Besides, we also need the fonts to be accessible during dev mode (
.temp). I'll open an issue in VuePress.