fix(components): remove duplicate event handlers (#462)

fixes #453
vuesion · Sep 21, 2019 · 0abd6e5 · 0abd6e5
1 parent 477a207
commit 0abd6e5
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 31 deletions.
diff --git a/src/app/shared/components/VueInput/VueInput.vue b/src/app/shared/components/VueInput/VueInput.vue
@@ -14,7 +14,12 @@
       :class="[value ? $style.hasValue : '']"
       :autofocus="autofocus"
       v-bind="$attrs"
-      v-on="handlers"
+      v-on="{
+        ...this.$listeners,
+        input: (e) => {
+          $emit('input', e.target.value);
+        },
+      }"
       ref="input"
     />
     <span :class="$style.bar"></span>
@@ -99,16 +104,6 @@ export default {
 
       return classes;
     },
-    handlers() {
-      delete this.$listeners.input;
-
-      return {
-        ...this.$listeners,
-        input: (e: any) => {
-          this.$emit('input', e.target.value);
-        },
-      };
-    },
   },
   data(): any {
     return {

diff --git a/src/app/shared/components/VueSelect/VueSelect.vue b/src/app/shared/components/VueSelect/VueSelect.vue
@@ -10,7 +10,10 @@
       :disabled="disabled"
       :autocomplete="autocomplete"
       v-bind="$attrs"
-      v-on="handlers"
+      v-on="{
+        ...this.$listeners,
+        input: onInput,
+      }"
     >
       <option v-for="(option, idx) in selectOptions" :key="idx" :value="option.value" :selected="isSelected(option)">
         {{ option.label }}
@@ -109,14 +112,6 @@ export default {
     currentValueAsArray(): string[] {
       return this.value.split('|');
     },
-    handlers() {
-      delete this.$listeners.input;
-
-      return {
-        ...this.$listeners,
-        input: this.onInput,
-      };
-    },
   },
   methods: {
     isSelected(option: IVueSelectOption): boolean {

diff --git a/src/app/shared/components/VueTextarea/VueTextarea.vue b/src/app/shared/components/VueTextarea/VueTextarea.vue
@@ -12,7 +12,12 @@
       :class="[value ? $style.hasValue : '']"
       :autofocus="autofocus"
       v-bind="$attrs"
-      v-on="handlers"
+      v-on="{
+        ...this.$listeners,
+        input: (e) => {
+          $emit('input', e.target.value);
+        },
+      }"
       ref="input"
     ></textarea>
     <span :class="$style.bar"></span> <label :for="name"> {{ placeholder }}<sup v-if="required">*</sup> </label>
@@ -88,16 +93,6 @@ export default {
 
       return classes;
     },
-    handlers() {
-      delete this.$listeners.input;
-
-      return {
-        ...this.$listeners,
-        input: (e: any) => {
-          this.$emit('input', e.target.value);
-        },
-      };
-    },
   },
   data(): any {
     return {