feat(components): add star rating #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devCrossNet
reviewed
Jul 19, 2019
livkndt
changed the title
|
@devCrossNet in the example provided in the issue, there are a fair few variations on the component (#192) like half stars, all the way to 'glowing' stars. Do you have a view on which of these are useful to include? Otherwise could merge this as a v1 & improve later :) Also, was thinking some feedback on star click would be nice to be clear you clicked on a star. |
|
I think half stars would be good for displaying, not necessarily for selection. Simple use-case one user gives 5 stars, another one gives 3 - display would be 4,5 stars. I like the idea of the visual feedback on click, maybe @einfalles has some ideas for this component, too? |
devCrossNet
force-pushed
the
feat/vue-star-rating-component
branch
from
45b6512
to
657c6f0
Compare
devCrossNet
force-pushed
the
feat/vue-star-rating-component
branch
from
657c6f0
to
a00b537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is accomplished by your PR?
Create new star rating component as suggested in: #192
WIP!
Need to add full test coverage & look at greater flexibility/customisability for the component
Is there something controversial in your PR?
please take a moment to tell us about your choices...
Link to the Issue
or a link to a ticket system...
Checklist
New Feature / Bug Fix