Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: implements helmet #433

Merged
merged 2 commits into from
Aug 13, 2019
Merged

chore: implements helmet #433

merged 2 commits into from
Aug 13, 2019

Conversation

tamer-mohamed
Copy link
Contributor

@tamer-mohamed tamer-mohamed commented Aug 13, 2019 •
edited

What is accomplished by your PR?

closes #432

Is there something controversial in your PR?

please take a moment to tell us about your choices...

Link to the Issue

#432

Checklist

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing
  • Add new passing unit tests to cover the code introduced by your PR
  • Change documentation for the code introduced by your PR
  • Add Story / Design System Page for a new component introduced by your PR

@devCrossNet
Copy link
Member

Thank you @tamer-mohamed. Can you check if we can get rid of existing header logic?

https://github.com/vuesion/vuesion/blob/master/src/server/routes/SSRRoutes.ts#L26

https://github.com/vuesion/vuesion/blob/master/src/server/utils/Utils.ts#L13

@tamer-mohamed
Copy link
Contributor Author

tamer-mohamed commented Aug 13, 2019 •
edited

@devCrossNet nice one - d10e5a9

@devCrossNet devCrossNet changed the base branch from master to next August 13, 2019 18:27
devCrossNet
devCrossNet approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@devCrossNet devCrossNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I changed the base branch to next

@devCrossNet devCrossNet merged commit 4b41a33 into next Aug 13, 2019
@devCrossNet devCrossNet deleted the chore/helmet branch August 13, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devCrossNet devCrossNet devCrossNet approved these changes

Assignees

@tamer-mohamed tamer-mohamed

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tamer-mohamed @devCrossNet