Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vue-router to handle anchors #65

Merged
merged 2 commits into from Mar 6, 2018
Merged

Conversation

40818419
Copy link
Contributor

@40818419 40818419 commented Mar 1, 2018

What is accomplished by your PR?

Allow router to handle anchors e.g /foo#bar

Link to the Issue

Fixed with #64

Checklist

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing
  • Add new passing unit tests to cover the code introduced by your PR

Copy link
Member

@devCrossNet devCrossNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #65   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          53     53           
  Lines         995    995           
  Branches      123    123           
=====================================
  Hits          995    995

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad535d...d0c8e24. Read the comment docs.

@devCrossNet devCrossNet merged commit 7876962 into master Mar 6, 2018
@devCrossNet devCrossNet deleted the feat/handle-anchors branch March 6, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants