-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Project is not building #176
Comments
@Baroshem please add this issue to the correct Project & Milestone 🙏🏼 |
Thanks for reporting that! I have added it to 1.2.0 |
Hi @rjdmacedo I've tried to reproduce this error but I can't see it. It could be fixed in core so can you check it again? |
@justyna-13 check your Talked with @filipsobol about this issue and he told me that they had indeed removed that Quoting 👇🏼
|
It's "@vue-storefront/core@~2.4.1" |
Expected Behavior
As a software engineer I expect to build the project without any errors.
Actual Behavior
When I run
yarn build
oryarn dev
I get an error that will interrupt the build process.Possible Solution
In
packages/composables/src/getters/checkoutGetters.ts
remove one import (*1) and remove the typescript typing oncheckoutGetters
object (*2)*1 -
import { CheckoutGetters } from '@vue-storefront/core';
*2 -
export const checkoutGetters: CheckoutGetters<ShippingMethod> { ... }
Steps to reproduce
git pull
ondevelop
branchyarn install
yarn dev
(oryarn build
)What version of vendure integration are you using?
@vue-storefront/core@2.4.6
What version of Node.js are you using?
v16.13.2
What browser (and version) are you using?
CLI
What operating system (and version) are you using?
macOS
Relevant log output
Code of Conduct
The text was updated successfully, but these errors were encountered: