Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Project is not building #176

Closed
1 task done
rjdmacedo opened this issue Feb 15, 2022 · 5 comments · Fixed by #183
Closed
1 task done

[Bug]: Project is not building #176

rjdmacedo opened this issue Feb 15, 2022 · 5 comments · Fixed by #183
Assignees
Labels
bug Something isn't working hackathon
Projects

Comments

@rjdmacedo
Copy link
Collaborator

Expected Behavior

As a software engineer I expect to build the project without any errors.

Actual Behavior

When I run yarn build or yarn dev I get an error that will interrupt the build process.

Possible Solution

In packages/composables/src/getters/checkoutGetters.ts remove one import (*1) and remove the typescript typing on checkoutGetters object (*2)

*1 - import { CheckoutGetters } from '@vue-storefront/core';
*2 - export const checkoutGetters: CheckoutGetters<ShippingMethod> { ... }

Steps to reproduce

  1. run git pull on develop branch
  2. run yarn install
  3. run yarn dev (or yarn build)

What version of vendure integration are you using?

@vue-storefront/core@2.4.6

What version of Node.js are you using?

v16.13.2

What browser (and version) are you using?

CLI

What operating system (and version) are you using?

macOS

Relevant log output

[!] (plugin rpt2) Error: /.../.../.../vue-storefront-community/vendure/packages/composables/src/getters/checkoutGetters.ts(1,10): semantic error TS2305: Module '"@vue-storefront/core"' has no exported member 'CheckoutGetters'.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rjdmacedo rjdmacedo added the bug Something isn't working label Feb 15, 2022
@rjdmacedo
Copy link
Collaborator Author

@Baroshem please add this issue to the correct Project & Milestone 🙏🏼

@Baroshem Baroshem added this to To do in 1.2.0 via automation Feb 15, 2022
@Baroshem Baroshem added this to the 1.2.0 milestone Feb 15, 2022
@Baroshem
Copy link
Collaborator

Thanks for reporting that! I have added it to 1.2.0

@justyna-13 justyna-13 self-assigned this Mar 3, 2022
@justyna-13
Copy link
Contributor

Hi @rjdmacedo I've tried to reproduce this error but I can't see it. It could be fixed in core so can you check it again?

@rjdmacedo
Copy link
Collaborator Author

@justyna-13 check your yarn.lock and see what version of @vue-storefront/core you are using.

Talked with @filipsobol about this issue and he told me that they had indeed removed that CheckoutGetters member.

Quoting 👇🏼

In the past we had checkoutGetters and useCheckout but it was impossible to enclose all checkout logic (especially because each integration is very different in how they deal with the checkout process) that we replaced them with more granular alternatives

@justyna-13
Copy link
Contributor

It's "@vue-storefront/core@~2.4.1"

@justyna-13 justyna-13 linked a pull request Mar 3, 2022 that will close this issue
9 tasks
1.2.0 automation moved this from To do to Done Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hackathon
Projects
No open projects
1.2.0
Done
Development

Successfully merging a pull request may close this issue.

3 participants