Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Get the default store language and currency from vendure #180

Closed
1 task done
KeetTechSol opened this issue Mar 2, 2022 · 4 comments
Closed
1 task done
Labels
enhancement New feature or request
Projects

Comments

@KeetTechSol
Copy link

KeetTechSol commented Mar 2, 2022

How the project can be improved?

Since my customers are based only in the UK and they do not sell items to other countries, the default language is en_GB and the currency is GBP in vendure. It will be great if storefront can pick up these from the backend.

What are the acceptance criteria?

  • [ ]

Additional information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@KeetTechSol KeetTechSol added the enhancement New feature or request label Mar 2, 2022
@Baroshem
Copy link
Collaborator

Baroshem commented Mar 3, 2022

Hi @KeetTechSol

Thanks for raising this issue. Indeed its quite useful feature. I will add it to our next major release roadmap :)

@Baroshem
Copy link
Collaborator

Baroshem commented Mar 7, 2022

@KeetTechSol

Could you take a look at this? #163

Maybe it can solve your issue already?

@KeetTechSol
Copy link
Author

@Baroshem
If I understand correctly, #163 gets currency for the current locale, which is selected in the storefront. The default locale is still hardcoded in the storefront. My suggestion is when vendure is connected, the storefront's default language and currency should align to that of vendure.
Hope I am not confusing you.

@Baroshem Baroshem added this to To do in 2.0.0 May 12, 2022
@Baroshem
Copy link
Collaborator

Baroshem commented Aug 5, 2022

Closing as there is no further requirement for the feature.

@Baroshem Baroshem closed this as completed Aug 5, 2022
2.0.0 automation moved this from To do to Done Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
2.0.0
Done
Development

No branches or pull requests

2 participants