refactor!: refactor the useApi composable #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add graphql-tag - remove count from filters
bartoszherba
force-pushed
the
M2-780-refactor-use-api
branch
from
628dd2a
to
aaf9ae2
Compare
Frodigo
previously approved these changes
Jun 9, 2022
- update unit tests
bartoszherba
changed the title
Frodigo
approved these changes
Jun 10, 2022
Frodigo
changed the title
Frodigo
changed the title
sethidden
added a commit
that referenced
this pull request
Jun 30, 2022
This reverts commit 9b8de85. This change was made because K6 recorded tests are gigantic when customQuery sends the GraphQL AST in the request body. After this change, this the request is sent in string form, but is converted into GraphQL AST on the middleware side (because Apollo GraphQL client expects AST (DocumentNode TS type), not string)
sethidden
added a commit
that referenced
this pull request
Jun 30, 2022
This commit adds a GitHub Actions workflow (you have to *manually* trigger it) that uses the K6 load testing utillity to run tests on a given environment. I had to add the `K6_API_TOKEN` secret to GitHub to allow running the tests in K6's cloud (VSF has a paid plan). You can also run the test on GitHub's agent though. M2-899 fix: use js, not ts file chore: partially revert #1107 This reverts commit 9b8de85. This change was made because K6 recorded tests are gigantic when customQuery sends the GraphQL AST in the request body. After this change, this the request is sent in string form, but is converted into GraphQL AST on the middleware side (because Apollo GraphQL client expects AST (DocumentNode TS type), not string) test(load): improve gql requests refactor: fix newlines
sethidden
added a commit
that referenced
this pull request
Jun 30, 2022
This commit adds a GitHub Actions workflow (you have to *manually* trigger it) that uses the K6 load testing utillity to run tests on a given environment. I had to add the `K6_API_TOKEN` secret to GitHub to allow running the tests in K6's cloud (VSF has a paid plan). You can also run the test on GitHub's agent though. M2-899 fix: use js, not ts file chore: partially revert #1107 This reverts commit 9b8de85. This change was made because K6 recorded tests are gigantic when customQuery sends the GraphQL AST in the request body. After this change, this the request is sent in string form, but is converted into GraphQL AST on the middleware side (because Apollo GraphQL client expects AST (DocumentNode TS type), not string) test(load): improve gql requests refactor: fix newlines
sethidden
added a commit
that referenced
this pull request
Jun 30, 2022
This commit adds a GitHub Actions workflow (you have to *manually* trigger it) that uses the K6 load testing utillity to run tests on a given environment. I had to add the `K6_API_TOKEN` secret to GitHub to allow running the tests in K6's cloud (VSF has a paid plan). You can also run the test on GitHub's agent though. M2-899 fix: use js, not ts file chore: partially revert #1107 This reverts commit 9b8de85. This change was made because K6 recorded tests are gigantic when customQuery sends the GraphQL AST in the request body. After this change, this the request is sent in string form, but is converted into GraphQL AST on the middleware side (because Apollo GraphQL client expects AST (DocumentNode TS type), not string) test(load): improve gql requests refactor: fix newlines
sethidden
added a commit
that referenced
this pull request
Jun 30, 2022
This commit adds a GitHub Actions workflow (you have to *manually* trigger it) that uses the K6 load testing utillity to run tests on a given environment. I had to add the `K6_API_TOKEN` secret to GitHub to allow running the tests in K6's cloud (VSF has a paid plan). You can also run the test on GitHub's agent though. M2-899 fix: use js, not ts file chore: partially revert #1107 This reverts commit 9b8de85. This change was made because K6 recorded tests are gigantic when customQuery sends the GraphQL AST in the request body. After this change, this the request is sent in string form, but is converted into GraphQL AST on the middleware side (because Apollo GraphQL client expects AST (DocumentNode TS type), not string) test(load): improve gql requests refactor: fix newlines
sethidden
added a commit
that referenced
this pull request
Jun 30, 2022
This commit adds a GitHub Actions workflow (you have to *manually* trigger it) that uses the K6 load testing utillity to run tests on a given environment. I had to add the `K6_API_TOKEN` secret to GitHub to allow running the tests in K6's cloud (VSF has a paid plan). You can also run the test on GitHub's agent though. M2-899 fix: use js, not ts file chore: partially revert #1107 This reverts commit 9b8de85. This change was made because K6 recorded tests are gigantic when customQuery sends the GraphQL AST in the request body. After this change, this the request is sent in string form, but is converted into GraphQL AST on the middleware side (because Apollo GraphQL client expects AST (DocumentNode TS type), not string) test(load): improve gql requests refactor: fix newlines
sethidden
added a commit
that referenced
this pull request
Jun 30, 2022
This commit adds a GitHub Actions workflow (you have to *manually* trigger it) that uses the K6 load testing utillity to run tests on a given environment. I had to add the `K6_API_TOKEN` secret to GitHub to allow running the tests in K6's cloud (VSF has a paid plan). You can also run the test on GitHub's agent though. M2-899 fix: use js, not ts file chore: partially revert #1107 This reverts commit 9b8de85. This change was made because K6 recorded tests are gigantic when customQuery sends the GraphQL AST in the request body. After this change, this the request is sent in string form, but is converted into GraphQL AST on the middleware side (because Apollo GraphQL client expects AST (DocumentNode TS type), not string) test(load): improve gql requests refactor: fix newlines
Frodigo
pushed a commit
that referenced
this pull request
Jul 4, 2022
This commit adds a GitHub Actions workflow (you have to *manually* trigger it) that uses the K6 load testing utillity to run tests on a given environment. I had to add the `K6_API_TOKEN` secret to GitHub to allow running the tests in K6's cloud (VSF has a paid plan). You can also run the test on GitHub's agent though. M2-899 fix: use js, not ts file chore: partially revert #1107 This reverts commit 9b8de85. This change was made because K6 recorded tests are gigantic when customQuery sends the GraphQL AST in the request body. After this change, this the request is sent in string form, but is converted into GraphQL AST on the middleware side (because Apollo GraphQL client expects AST (DocumentNode TS type), not string) test(load): improve gql requests refactor: fix newlines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor: refactor use api
- add graphql-tag
- remove count from filters
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: