Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed wrong values of selected configurable product variants #1178

Conversation

Frodigo
Copy link
Member

@Frodigo Frodigo commented Jun 29, 2022

Before this PR, the last option of configurable was added to the cart instead of the option selected by the user.

M2-860
Screenshot 2022-06-29 at 08 13 30

@Frodigo Frodigo added this to the 1.0.0-rc.10 milestone Jun 29, 2022
sethidden
sethidden previously approved these changes Jun 29, 2022
Copy link
Contributor

@sethidden sethidden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment but it's not that important

…ddItemCommand.ts

Co-authored-by: Artur Tagisow <5359825+sethidden@users.noreply.github.com>
@Frodigo Frodigo requested a review from sethidden June 29, 2022 07:15
@Frodigo
Copy link
Member Author

Frodigo commented Jun 29, 2022

@sethidden I added your suggestion, please approve again.

@Frodigo Frodigo merged commit 256f0dd into develop Jun 29, 2022
@Frodigo Frodigo deleted the M2-860-cart-checkout-size-and-colour-values-are-wrongly-displayed-in-mini-cart-and-checkout-payment branch June 29, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants