Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make security connection optional by default #1354

Merged

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Sep 5, 2022

Description

A lot of people had problems with setting up security connection locally. This PR makes the secure connection optional.

Related Issue

Motivation and Context

Developer experience improvement

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba force-pushed the feat/make-security-connection-optional-by-default branch 3 times, most recently from 2f355a5 to 2e21914 Compare September 5, 2022 08:13
@bartoszherba bartoszherba force-pushed the feat/make-security-connection-optional-by-default branch from 2e21914 to 95eb6a1 Compare September 5, 2022 08:46
@bartoszherba bartoszherba merged commit ccf1704 into develop Sep 5, 2022
@bartoszherba bartoszherba deleted the feat/make-security-connection-optional-by-default branch September 5, 2022 11:16
@bartoszherba bartoszherba added this to the 1.1.0 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants