fix(default-theme): sync up data in some filter component (#2009)

vuestorefront · Oct 11, 2023 · 7b9685d · 7b9685d
1 parent bf0eca9
commit 7b9685d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/packages/default-theme/src/components/listing/types/range.vue b/packages/default-theme/src/components/listing/types/range.vue
@@ -22,12 +22,10 @@
   </div>
 </template>
 <script>
-import { computed, ref } from "@vue/composition-api"
-
+import { watch, ref } from "@vue/composition-api"
 import { SfFilter, SfHeading } from "@storefront-ui/vue"
 import SwInput from "@/components/atoms/SwInput.vue"
 import useVuelidate from "@vuelidate/core"
-import { required, email } from "@vuelidate/validators"
 
 export default {
   components: {
@@ -72,6 +70,19 @@ export default {
         value: max.value,
       })
     }
+
+    watch(() => props.currentFilters[minFilterCode], (v) => {
+      if (min.value !== v) {
+        min.value = v;
+      }
+    });
+
+    watch(() => props.currentFilters[maxFilterCode], (v) => {
+      if (max.value !== v) {
+        max.value = v;
+      }
+    });
+
     return {
       min,
       max,

diff --git a/packages/default-theme/src/components/listing/types/shipping-free.vue b/packages/default-theme/src/components/listing/types/shipping-free.vue
@@ -14,8 +14,6 @@
   </div>
 </template>
 <script>
-import { computed, ref } from "@vue/composition-api"
-
 import { SfFilter, SfHeading } from "@storefront-ui/vue"
 import SwInput from "@/components/atoms/SwInput.vue"
 import SwCheckbox from "@/components/atoms/SwCheckbox.vue"
@@ -30,7 +28,7 @@ export default {
   },
   data() {
     return {
-      selected: this.currentFilters[this.filter.code] === "true",
+      selected: this.currentFilters[this.filter.code] === true,
     }
   },
   props: {
@@ -43,6 +41,11 @@ export default {
       default: () => ({}),
     },
   },
+  watch: {
+    currentFilters(val) {
+      this.selected = val[this.filter.code] === true;
+    },
+  },
 }
 </script>
 <style lang="scss" scoped>