feat(default-theme): Improve SwImage component with srcset #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
patzick
requested changes
Jun 6, 2022
| imgUrl() { | ||
| return getResizedImage(this.getMedia && this.getMedia.url) | ||
| imagesUrl() { | ||
| return this.getMedia ? this.getMedia.thumbnails : [] |
There was a problem hiding this comment.
Suggested change
| return this.getMedia ? this.getMedia.thumbnails : [] | |
| return this.getMedia?.thumbnails ?? [] |
| setup(props, { root }) { | ||
| const width = (props.imageWidth && props.imageWidth + "px") || "100%" | ||
| const height = (props.imageHeight && props.imageHeight + "px") || "100%" | ||
| return { | ||
| placeholder: getPlaceholderImage(width, height), | ||
| } | ||
| }, | ||
| computed: { | ||
| srcsets () { | ||
| return this.srcset ? this.srcset.map(item => ({ |
There was a problem hiding this comment.
let's move these computed properties to setup method, example:
const srcsets = computed(() => props.srcset?.map(item => ({
src: item.url,
width: item.width,
resolution: item.width
}) ?? []
)
quando1910
force-pushed
the
feat/improve-swimage-with-srcset
branch
from
33b2600
to
7d02980
Compare
…eat/improve-swimage-with-srcset
|
💙 shopware-pwa-test-europe-west1-gcp-storefrontcloud-io successfully deployed at https://4bcba761eed8f37e370250ddbda0f8bd9025f925.shopware-pwa-test.preview.europe-west1.gcp.storefrontcloud.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR closes #1884
Changes
srcsetfor SwImage component.Checklist