fix(SfSelect): disabled state attributes

vuestorefront · Aug 7, 2023 · 1667e4f · 1667e4f
1 parent 564ce82
commit 1667e4f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.changeset/wise-bananas-build.md b/.changeset/wise-bananas-build.md
@@ -0,0 +1,6 @@
+---
+'@storefront-ui/react': patch
+'@storefront-ui/vue': patch
+---
+
+Remove redundant `selected` attribute from `SfSelect` placeholder
diff --git a/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx b/packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx
@@ -64,7 +64,6 @@ export default function SfSelect(props: SfSelectProps) {
         {placeholder && (
           <option
             disabled
-            selected
             hidden
             value=""
             className={classNames('bg-neutral-300 text-sm', {

diff --git a/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue b/packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue
@@ -84,7 +84,6 @@ const modelProxy = computed({
       <option
         v-if="placeholder"
         disabled
-        selected
         hidden
         class="text-sm bg-neutral-300"
         value=""