feat: add Badge base component #2730
Conversation
🦋 Changeset detectedLatest commit: d745129 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aniamusial
requested review from
Szymon-dziewonski,
FRSgit and
mattmaribojoc
as code owners
packages/sfui/frameworks/react/components/SfIcons/SfIconAddShoppingCart.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Please do not forget add changeset to your PR
here's draft of how to do it https://vsf.atlassian.net/wiki/spaces/SFUI/pages/147750931/Continuous+delivery+pipeline+draft
rest is looking good, great job @aniamusial and @dkacper
Co-authored-by: Szymon Dziewoński <szymon.dziewonski@gmail.com>
Co-authored-by: Szymon Dziewoński <szymon.dziewonski@gmail.com>
| @@ -0,0 +1,32 @@ | |||
| <template> | |||
| <div class="flex gap-3"> | |||
| <SfButton class="relative" square variant="tertiary"> | |||
There was a problem hiding this comment.
I think we should add relative to SfButton, wdyt ? cc: @FRSgit
There was a problem hiding this comment.
Yes, we could - but that would be a breaking change, so let's do it separately on v3.0.0 branch
Co-authored-by: Szymon Dziewoński <szymon.dziewonski@gmail.com>
Co-authored-by: Szymon Dziewoński <szymon.dziewonski@gmail.com>
|
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed! |
|
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
LGTM after all the changes by @aniamusial. I'm happy to approve this PR. Let's merge the badge. ⭐
Related issue
Closes SFUI2-638
Scope of work
What's done:
Screenshots of visual changes
Checklist