Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (sfui2-1089) additional search blocks #2746

Merged
merged 11 commits into from
May 31, 2023
Merged

Conversation

aniamusial
Copy link
Contributor

@aniamusial aniamusial commented May 25, 2023

Related issue

https://vsf.atlassian.net/browse/SFUI2-1089?atlOrigin=eyJpIjoiOWIzOTFkYzEyYmZmNDM1ZjhiMDY1NzUwMDE5Njc5OGQiLCJwIjoiaiJ9

Scope of work

  • created SearchWithIcon and SearchWithImage blocks for vue and react
  • updated documentation
  • changed invalid button types for SearchBasic

Screenshots of visual changes

Zrzut ekranu 2023-05-25 o 12 33 22 Zrzut ekranu 2023-05-25 o 12 33 32

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@aniamusial aniamusial marked this pull request as ready for review May 25, 2023 11:36
@aniamusial aniamusial changed the title feat: (sfui2-1089) feat: (sfui2-1089) additional search blocks May 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

🦋 Changeset detected

Latest commit: 1d77252

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@storefront-ui/react Minor
@storefront-ui/vue Minor
@storefront-ui/shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@dkacper dkacper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

Comment on lines +160 to +161
{ id: 'j-dre', name: 'jacket dress', thumbnail: SfIconSearch },
{ id: 'dr-cat', name: 'dresses', thumbnail: SfIconGridView },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to find dr-dre 😂

@aniamusial aniamusial merged commit 74dfce2 into v2-develop May 31, 2023
13 checks passed
@aniamusial aniamusial deleted the feat/sfui2-1089 branch May 31, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants