Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rating button #2820

Merged
merged 9 commits into from
Jun 15, 2023
Merged

feat: rating button #2820

merged 9 commits into from
Jun 15, 2023

Conversation

dkacper
Copy link
Contributor

@dkacper dkacper commented Jun 13, 2023 •
edited by jira bot
Loading

Related issue

Closes SFUI2-673

Scope of work

This PR adds new base component – SfRatingButton.

Screenshots of visual changes

rating button

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 47bea10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Szymon-dziewonski
Szymon-dziewonski reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@Szymon-dziewonski Szymon-dziewonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR !

For vue sizes are not selected and for react all are selected, can we please have it unified
Vue
image

React
image

packages/sfui/frameworks/react/components/SfRatingButton/SfRatingButton.tsx Outdated Show resolved Hide resolved
packages/sfui/frameworks/react/components/SfRatingButton/types.ts Outdated Show resolved Hide resolved
packages/sfui/frameworks/vue/components/SfRatingButton/SfRatingButton.vue Outdated Show resolved Hide resolved
Szymon-dziewonski
Szymon-dziewonski reviewed Jun 14, 2023
View reviewed changes
packages/sfui/frameworks/vue/components/SfRatingButton/SfRatingButton.vue
Comment on lines +55 to +59
const iconSize: Record<SfRatingButtonSize, SfRatingButtonIconSize> = {
[SfRatingButtonSize.sm]: SfIconSize.base,
[SfRatingButtonSize.base]: SfIconSize.lg,
[SfRatingButtonSize.lg]: SfIconSize.xl,
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can extract this outside component as well

Szymon-dziewonski
Szymon-dziewonski reviewed Jun 14, 2023
View reviewed changes
packages/tests/components/SfRatingButton/SfRatingButton.cy.tsx Outdated
Comment on lines 10 to 21
interface Props {
value?: number;
onChange?: (value: number) => void;
max?: number;
name?: string;
disabled?: boolean;
label?: string;
labelClassName?: string;
size?: `${SfRatingButtonSize}`;
getLabelText?: (value: number) => string;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: those are copy paste from https://github.com/vuestorefront/storefront-ui/pull/2820/files#diff-8fcdae6ac93bc10b998e13c1280c073dd3e3ff2cac241eafea1e74d5ebe84ca0R13 why not reuse those ?

FRSgit
FRSgit approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@FRSgit FRSgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side!

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@dkacper dkacper merged commit 5a13fef into v2-develop Jun 15, 2023
13 checks passed
@dkacper dkacper deleted the feat/sfui2-673-rating-button branch June 15, 2023 09:35
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Szymon-dziewonski Szymon-dziewonski Szymon-dziewonski left review comments

@FRSgit FRSgit FRSgit approved these changes

@mattmaribojoc mattmaribojoc Awaiting requested review from mattmaribojoc mattmaribojoc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkacper @Szymon-dziewonski @FRSgit