fix: importing types from a local file instead of the package in SfBadge #2939
Conversation
filrak
requested review from
Szymon-dziewonski,
FRSgit,
dkacper and
mattmaribojoc
as code owners
🦋 Changeset detectedLatest commit: 80c0da2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @filrak, thank you for contribution, however there are couple issues with code. I left one comment and also please replace exports in SfBadge/index.ts This is due to how aliases locally works in vite, so we would not need to build during developement. Also since this PR is If its more suitable for you I can take it over and finish this PR. |
Co-authored-by: Szymon Dziewoński <szymon.dziewonski@gmail.com>
Szymon-dziewonski
changed the title
|
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!
|
|
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!
|
…dge (#2939) --------- Co-authored-by: Szymon Dziewoński <szymon.dziewonski@gmail.com>
Related issue
Closes #
Scope of work
I just changed the import statement to point to the package
Screenshots of visual changes
Checklist