Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SfScrollable): aria label casing [SFUI2-1306] #2946

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix(SfScrollable): aria label casing [SFUI2-1306] #2946

merged 1 commit into from
Aug 7, 2023

Conversation

jagoral
Copy link
Contributor

@jagoral jagoral commented Aug 7, 2023 •
edited
Loading

Related issue

https://vsf.atlassian.net/browse/SFUI2-1306

Scope of work

Changed ariaLabel attribute to aria-label.

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 979c29e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@storefront-ui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jagoral jagoral force-pushed the fix--sfscrollable-aria-attributes branch from fd290c6 to 6eab5b0 Compare August 7, 2023 08:46
@jagoral jagoral force-pushed the fix--sfscrollable-aria-attributes branch from 6eab5b0 to 979c29e Compare August 7, 2023 08:46
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Szymon-dziewonski
Szymon-dziewonski approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@Szymon-dziewonski Szymon-dziewonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR :)

@jagoral jagoral merged commit 12622cd into v2-develop Aug 7, 2023
16 checks passed
@jagoral jagoral deleted the fix--sfscrollable-aria-attributes branch August 7, 2023 14:05
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Szymon-dziewonski Szymon-dziewonski Szymon-dziewonski approved these changes

@FRSgit FRSgit Awaiting requested review from FRSgit FRSgit is a code owner

@dkacper dkacper Awaiting requested review from dkacper

@mattmaribojoc mattmaribojoc Awaiting requested review from mattmaribojoc mattmaribojoc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jagoral @Szymon-dziewonski