-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add typography-hint-xs and typography-error-xs classes #3006
Conversation
🦋 Changeset detectedLatest commit: 8bd3159 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1d8fbe0
to
2d4e460
Compare
[storefront-ui-vue] Please retry analysis of this Pull-Request directly on SonarCloud. |
apps/preview/nuxt/pages/showcases/Checkout/CheckoutAddressForm.vue
Outdated
Show resolved
Hide resolved
2d4e460
to
dcbf42a
Compare
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Related issue
#2981
Scope of work
Add new types for typography plugin,
typography-hint-xs
andtypography-error-xs
Figma: https://www.figma.com/file/CWOkbpne0tDpSenT4ZEUTQ/%F0%9F%9B%A0-SFUI-2-%7C-Design-Kit-v2.6-(development)?node-id=19478%3A53189&mode=dev
Fix wrong styling or missing gaps in hint, replace text-xs into typography-hint-xs
Screenshots of visual changes
Checklist