Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Entering an invalid promo code makes cart appear empty #132

Closed
1 task done
michaelbromley opened this issue Nov 3, 2021 · 0 comments · Fixed by #139
Closed
1 task done

[Bug]: Entering an invalid promo code makes cart appear empty #132

michaelbromley opened this issue Nov 3, 2021 · 0 comments · Fixed by #139
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@michaelbromley
Copy link
Collaborator

Expected Behavior

When entering an invalid promo code, the cart should be unaffected. Probably an error message should be displayed somewhere though.

Actual Behavior

The cart goes empty, but refreshing the page reveals it to not actually be empty.

vsf-issue-bad-promo-code.mp4

Possible Solution

Seems like it might be related to incorrectly handling the ErrorResult CouponCodeInvalidError that you get with an invalid code.

Steps to reproduce

As above

What version of vendure integration are you using?

1.0.0-beta.3

What version of Node.js are you using?

16.x

What browser (and version) are you using?

Brave (Chromium 95)

What operating system (and version) are you using?

Windows 10

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@michaelbromley michaelbromley added the bug Something isn't working label Nov 3, 2021
@Baroshem Baroshem added this to To do in 1.0.0 via automation Nov 3, 2021
@Baroshem Baroshem added this to the 1.0.0 milestone Nov 3, 2021
@Baroshem Baroshem moved this from To do to In progress in 1.0.0 Nov 24, 2021
@Baroshem Baroshem self-assigned this Nov 24, 2021
Baroshem added a commit that referenced this issue Nov 24, 2021
Baroshem added a commit that referenced this issue Nov 24, 2021
@Baroshem Baroshem mentioned this issue Nov 24, 2021
9 tasks
1.0.0 automation moved this from In progress to Done Nov 24, 2021
Baroshem added a commit that referenced this issue Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
1.0.0
Done
Development

Successfully merging a pull request may close this issue.

2 participants