We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When entering an invalid promo code, the cart should be unaffected. Probably an error message should be displayed somewhere though.
The cart goes empty, but refreshing the page reveals it to not actually be empty.
Seems like it might be related to incorrectly handling the ErrorResult CouponCodeInvalidError that you get with an invalid code.
CouponCodeInvalidError
As above
1.0.0-beta.3
16.x
Brave (Chromium 95)
Windows 10
No response
The text was updated successfully, but these errors were encountered:
fix: #132 fix coupon problem
0f5c0c2
fix: #132 run lint
9263686
Merge pull request #139 from vuestorefront/fix-#132/coupon
7ad409a
fix: #132 coupon
Baroshem
Successfully merging a pull request may close this issue.
Expected Behavior
When entering an invalid promo code, the cart should be unaffected. Probably an error message should be displayed somewhere though.
Actual Behavior
The cart goes empty, but refreshing the page reveals it to not actually be empty.
vsf-issue-bad-promo-code.mp4
Possible Solution
Seems like it might be related to incorrectly handling the ErrorResult
CouponCodeInvalidError
that you get with an invalid code.Steps to reproduce
As above
What version of vendure integration are you using?
1.0.0-beta.3
What version of Node.js are you using?
16.x
What browser (and version) are you using?
Brave (Chromium 95)
What operating system (and version) are you using?
Windows 10
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: