This repository has been archived by the owner on May 28, 2023. It is now read-only.
Bugfix/2918 #289
Merged
Bugfix/2918 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeromanowicz
suggested changes
Jul 2, 2019
… for backward compatibility with the price refacroting (@kkdg)
…e cases if `product.final_price` does not include the tax
|
Thanks for CR! Changelog updated + yarn.lock restored |
8 tasks
lukeromanowicz
approved these changes
Jul 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes #2918, #3050, #3099
Short description and why it's useful
I've fixed the naming convention of the prices field, got
final_priceto be used in price calculations + removed all theVue.prototype.*references introducing the new objectStorageManager