Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce coding guidelines with ESLint + TSLint + Prettier #1477

Closed
DavidRouyer opened this issue Aug 1, 2018 · 2 comments
Closed

Enforce coding guidelines with ESLint + TSLint + Prettier #1477

DavidRouyer opened this issue Aug 1, 2018 · 2 comments
Assignees
@patzick @lukeromanowicz
Labels
vs-hackathon Tasks for the Hackathon
Milestone
1.10.0-rc.1

Comments

@DavidRouyer
Copy link
Contributor

https://prettier.io/ is a pretty popular code formatter and it's integrated with a lot of tools.
@pkarw pkarw added enhancement / improvement vs-hackathon Tasks for the Hackathon labels Aug 1, 2018
@lukeromanowicz lukeromanowicz changed the title Enforce coding guidelines with Prettier Enforce coding guidelines with ESLint + TSLint + Prettier Apr 17, 2019
@lukeromanowicz
Copy link
Contributor

We need a preset of rules that will match in all three tools without causing conflicts

@lukeromanowicz lukeromanowicz mentioned this issue Apr 17, 2019
Closed
@lukeromanowicz lukeromanowicz modified the milestones: 1.10.0, 1.10.0-rc.1 Apr 17, 2019
@ResuBaka ResuBaka mentioned this issue May 1, 2019
Merged
8 tasks
patzick added a commit that referenced this issue May 23, 2019
@patzick
Merge pull request #2843 from ResuBaka/prettier-eslint-support
1aa03f1 
Eslint support #1477
@pkarw
Copy link
Collaborator

pkarw commented Jun 1, 2019

Please note the comment: #2843 (comment)

@patzick patzick mentioned this issue Jun 10, 2019
Merged
8 tasks
@pkarw pkarw closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patzick patzick

@lukeromanowicz lukeromanowicz

Labels
vs-hackathon Tasks for the Hackathon
Projects
None yet
Milestone
1.10.0-rc.1
Development

No branches or pull requests
5 participants
@pkarw @DavidRouyer @patzick @filrak @lukeromanowicz