Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes should be loaded per product #1975

Closed
pkarw opened this issue Nov 9, 2018 · 5 comments
Closed

Attributes should be loaded per product #1975

pkarw opened this issue Nov 9, 2018 · 5 comments
Assignees
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can

Comments

@pkarw
Copy link
Collaborator

pkarw commented Nov 9, 2018

What is the motivation for adding / enhancing this feature?

Currently, on the product page, we're loading all custom defined attributes. We're using attributes for the product options as well. IN some platforms like BigCommerce each product could have different attributes for options defined and this will end up with huge number of unique attributes.

We should be fetching the attributes meta per each product - getting the Object.keys(product) and then pre-fetching these attributes from Elastic.

@pkarw pkarw added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Nov 9, 2018
@filrak
Copy link
Collaborator

filrak commented Nov 9, 2018

probably it will also enable configurable options on product tiles

@pkarw pkarw closed this as completed Dec 18, 2018
@pkarw pkarw added this to the 1.7 | Performance milestone Dec 18, 2018
pkarw added a commit that referenced this issue Dec 19, 2018
@pkarw pkarw reopened this Jan 4, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Jan 4, 2019

We need to małe sure we’re loading also attributes listed in product.clnfogurable_optoons
The issue mentioned on Slack is caused by this issue probably https://vuestorefront.slack.com/archives/CA68P1JUF/p1546270863075300

@pkarw
Copy link
Collaborator Author

pkarw commented Jan 4, 2019

This line must be modified
https://github.com/DivanteLtd/vue-storefront/blob/6f187a646527b654bcfe1e79f558e258c2abf2cd/core/modules/catalog/store/product/actions.ts#L609

By adding the fields from configurable_options and/or switching off the “is_visible” “is_userdefined” filters. Maybe there is just an option like “is_configriable” in attribute collection?

@pkarw
Copy link
Collaborator Author

pkarw commented Jan 4, 2019

The attribute:list probably uses “OR” in query so maybe just extending the list of productFields will be enough - this is to be checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can
Projects
None yet
Development

No branches or pull requests

3 participants