Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the touch feedback animation (ripple effect) #199

Closed
karolbzik opened this issue Oct 29, 2017 · 8 comments
Closed

Add the touch feedback animation (ripple effect) #199

karolbzik opened this issue Oct 29, 2017 · 8 comments
Labels
good first issue Tasks that requires just basic understanding of Vue Storefront

Comments

@karolbzik
Copy link
Collaborator

Let's add the touch feedback animation from the material motion concept.
It's important for the touchscreens.
The effect should be applied to components: product blocks, buttons, buttons in the navigation, photos.

@karolbzik karolbzik added this to the To Be Planned milestone Oct 31, 2017
@karolbzik karolbzik added the good first issue Tasks that requires just basic understanding of Vue Storefront label Oct 31, 2017
@karolbzik
Copy link
Collaborator Author

@pkarw @patrykpiston @filrak @mercs600 could you suggest the approach?

@karolbzik karolbzik modified the milestones: To Be Planned, 0.2.0 PoC with the checkout and RWD Nov 6, 2017
@pkarw
Copy link
Collaborator

pkarw commented Nov 9, 2017

@filrak please take care of this one while finising checkout there is ready-made library for that for vue

@Aekal
Copy link
Collaborator

Aekal commented Nov 27, 2017

Can we use vue-material in the project? It'll much easier to follow material design concept with this library.

@pkarw
Copy link
Collaborator

pkarw commented Nov 27, 2017

@filrak ?

@pkarw pkarw modified the milestones: 0.2.0 PoC with the checkout and RWD, 0.3.0 PoC with full off-line capabilities Nov 30, 2017
@pkarw pkarw assigned kacperknapik and unassigned filrak Nov 30, 2017
@kacperknapik
Copy link
Collaborator

@pkarw @Aekal I think, we can use MdButton only at the moment.

If we need more components in the future, we can surely use the full bundle

@pkarw
Copy link
Collaborator

pkarw commented Dec 1, 2017

let's try

@kacperknapik
Copy link
Collaborator

unfortunately, vue-material is not exactly stable atm.
after using MdButton I get a similar error to this: vuematerial/vue-material#1182
we should consider using our own styles, and after vue-material is stable, we can use it

@pkarw
Copy link
Collaborator

pkarw commented Dec 1, 2017

OK :)

filrak added a commit that referenced this issue Dec 4, 2017
@pkarw pkarw closed this as completed Dec 5, 2017
@kacperknapik kacperknapik removed their assignment May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Development

No branches or pull requests

5 participants