-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO friendly urls #2010
Comments
|
Is it worth leveraging/porting the
The query returns the type of entity ( Example Query {
urlResolver(url: "venia-tops.html") {
id
canonical_url
type
}
} Result {
"data": {
"urlResolver": {
"id": 7,
"canonical_url": "catalog/category/view/id/7",
"type": "CATEGORY"
}
}
} |
@jahvi I’m not sure about it. The most challenging part of this feature to keep the offline cache working. As well resign from having the sku in url we must ensure that we store the cached products under url_key based keys in indexed db (please take a look at core/modules/catalog/store/product/actions.ts avtion single and how it’s caching the product) |
@madonzy we can probably store the Please take a look at #2021 - where I've described exactly how offline cache works |
@pkarw I see this sounds more complicated than I thought then, perhaps it might be too hard to implement with the current indexedDB approach. |
@jahvi I think we need to start with a modest solution based on |
I see, so you mean for example instead of having product keys in indexedDB as |
Correct. Either to map sku to url keys for lookup |
Any updates on this request? |
I am also wondering about this and if there are any updates on this issue? |
What about the current inconsistency between vsf and the underlying platform managing URLs, redirects, and what admins assume? |
Sorry I haven't been able to start work on this one as I've been working on other parts of VS. Feel free to submit a PR if anyone wants to give it a go 😃 |
Any feedback will be much appreciated: #2401 |
I have test this with an magento 1 store and the urls in category are /sku/url_key/ and in search they are /url_path?sku and when i try to go to a product like example http://localhost:3000/Aufschnittmaschine-ASM-300?childSku i get the error "The product, category or CMS page is not available in Offline mode. Redirecting to Home.". Is there anything i am missing? I am an the latest develop and have useUrlDispatcher and useShortCatalogUrls set to true. |
I belive You should have |
When I disable useShortCatalogUrls then the product url does work. But I want to have both at the same time. Or is it not intended to work together? |
It's not. Please set the |
@pkarw what do exactly mean with setting the ‘product.url_path’ and ‘category.url_path’ to any value? As these properties are now already filled by Mage2VueStorefront? |
Yes, these fields are set by mage2vuestorefornt and magento2-vsbridge-indexer and are used to map the urls |
What is the motivation for adding / enhancing this feature?
The urls that are being generated in the Vue Storefront are not SEO best practices, we would like to use product slugs without sku. Next to this issue it would be nice to have some kind of url rewrite possibility because now you have to allocate every module to a route like:
Category: /category-slug
Pages: /page/page-slug
Product: /product/123/product-url/123
I think we need to develop a general entry point for all types and from that point match if the slug is for a category, page or product.
What are the acceptance criteria
Can you complete this feature request by yourself?
No.
Additional information
None
The text was updated successfully, but these errors were encountered: