Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move entity types registration and gql queries on the module level #2028

Closed
yuriboyko opened this issue Nov 27, 2018 · 3 comments
Closed

Move entity types registration and gql queries on the module level #2028

yuriboyko opened this issue Nov 27, 2018 · 3 comments
Assignees
Labels
vs-hackathon Tasks for the Hackathon

Comments

@yuriboyko
Copy link
Contributor

yuriboyko commented Nov 27, 2018

What is the motivation for adding / enhancing this feature?

Currently all queries are located on the searchAdapter side each of them is related to the certain module work . So it probably make sense to move queries for search adapter on the module level

so each module should have search adapters folders structure
something like this:
'search-adapter'
-> 'graphql'
-> 'api'

where should be a registeration of all required for this module search adapter entity types

@filrak filrak added the vs-hackathon Tasks for the Hackathon label Jan 13, 2019
@lukeromanowicz
Copy link
Contributor

lukeromanowicz commented Jan 18, 2019

Related to #2225

@mirkocesaro
Copy link

mirkocesaro commented Feb 1, 2019

Hi @filrak, I and @nuovecode would like to take this issue for the hackathon5. Could you please assign to us?

@pkarw
Copy link
Collaborator

pkarw commented Feb 1, 2019

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

8 participants