Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move store/lib/search to core/lib/search #2225

Closed
filrak opened this issue Jan 17, 2019 · 2 comments
Closed

Move store/lib/search to core/lib/search #2225

filrak opened this issue Jan 17, 2019 · 2 comments
Assignees
@lukeromanowicz
Labels
vs-hackathon Tasks for the Hackathon
Milestone
1.8

Comments

@filrak
Copy link
Collaborator

filrak commented Jan 17, 2019

What is the motivation for adding / enhancing this feature?

As we are slowly getting rid of vs store package all the content from store/lib should be moved to core/lib folder. Since this one is pretty huge and have many imports it's a separate task

What are the acceptance criteria

  • store/lib/search is moved to core/lib/search
  • all imports are corrected
@filrak filrak added the vs-hackathon Tasks for the Hackathon label Jan 17, 2019
@lukeromanowicz
Copy link
Contributor

I'll take care of this one

@lukeromanowicz
Copy link
Contributor

@filrak
What do we do with store/lib/search.ts and store/lib/types/search? Moving first one is obvious but types don't really match core/lib pattern

This was referenced Jan 18, 2019
Merged
Closed
Merged
Closed
@filrak filrak closed this as completed Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukeromanowicz lukeromanowicz

Labels
vs-hackathon Tasks for the Hackathon
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@pkarw @filrak @lukeromanowicz