Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Clear button on Filters (desktop) #2342

Closed
ibugaj opened this issue Feb 2, 2019 · 3 comments
Closed

Lack of Clear button on Filters (desktop) #2342

ibugaj opened this issue Feb 2, 2019 · 3 comments
Assignees
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Milestone

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 2, 2019

Current behavior

Lack of Clear button on Filters (desktop)

Expected behavior

There should be Clear button

Steps to reproduce the issue

  1. Go to any Category of products
  2. Choose some attributes on Filter

image

Environment details

https://demo.storefrontcloud.io

Additional information

This button will be useful to easier changing user's choices

@pkarw pkarw added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Feb 2, 2019
@DaanKouters
Copy link
Collaborator

@patzick i'll pick this issue

@patzick patzick added the vs-hackathon Tasks for the Hackathon label Feb 12, 2019
@patzick patzick added this to the 1.9 milestone Feb 12, 2019
DaanKouters pushed a commit to DaanKouters/vue-storefront that referenced this issue Feb 12, 2019
@pkarw
Copy link
Collaborator

pkarw commented Feb 24, 2019

@patzick the button works fine but it’s visible when you got back from PDP however none of the filters are applied - that’s misslewding and it’s probably connected with the Iga’s issue about the filters state - seems like we just need to execute an event to run the products query - currently it’s executed with base Filter instead

@pkarw pkarw closed this as completed Feb 24, 2019
@ibugaj
Copy link
Collaborator Author

ibugaj commented Feb 25, 2019

Yes, I confirmed what @pkarw wrote - Clear button is and works, but there is problem with stated filters.
I noticed, that problem is with Colors, not Sizes, because if user choose Size and go on any PDP, then go back on PLP, then products are filtered according with it.

@patzick patzick modified the milestones: 1.9, 1.8.3 Feb 26, 2019
@ArturDivante ArturDivante added the QA approved on branch Testers will add this label after positive check on specific branch. label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

5 participants