Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong price flashing briefly when loading bundle product page #2371

Closed
jeremycharron opened this issue Feb 5, 2019 · 2 comments
Closed

Wrong price flashing briefly when loading bundle product page #2371

jeremycharron opened this issue Feb 5, 2019 · 2 comments
Labels
good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon
Milestone

Comments

@jeremycharron
Copy link

Current behavior

A wrong price is flashing briefly when loading/reloading a bundle product page.

Expected behavior

The right price should be showed right from the start OR the price should be hidden while loading

Steps to reproduce the issue

  1. Go on any bundle product page
  2. Reload the page
  3. Look for the price flashing for about 1 second

Environment details

https://demo.vuestorefront.io/p/24-WG080/sprite-yoga-companion-kit

@patzick
Copy link
Collaborator

patzick commented Feb 6, 2019

Thanks for issue. That behaviour is caused by setting default values on component mounted lifecycle, so after its rendered.

image

Although you haven't filled info if you're willing to improve it by yourself.
It's nice case for first issue:)

@patzick patzick added good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon labels Feb 6, 2019
@pkarw pkarw closed this as completed Feb 6, 2019
@pkarw
Copy link
Collaborator

pkarw commented Feb 6, 2019

It was an issue with setupAssociated called 2 times

pkarw added a commit that referenced this issue Feb 6, 2019
@patzick patzick mentioned this issue Feb 7, 2019
5 tasks
@patzick patzick added this to the 1.8 milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

3 participants