Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to check if module is already registered #2406

Closed
pkarw opened this issue Feb 10, 2019 · 7 comments
Closed

Add method to check if module is already registered #2406

pkarw opened this issue Feb 10, 2019 · 7 comments
Assignees
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can

Comments

@pkarw
Copy link
Collaborator

pkarw commented Feb 10, 2019

What is the motivation for adding / enhancing this feature?

We don't have a public method in VueStorefrontModule interface to check if the module has been already registered + list the registered modules.

It could be useful. For example, I wanted to check in payment-backend-methods if the ``payment-cash-on-delivery` has been registered and there was no way to do so

@pkarw pkarw added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Feb 10, 2019
@filrak
Copy link
Collaborator

filrak commented Feb 11, 2019

it's already added

@filrak filrak closed this as completed Feb 11, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Feb 11, 2019

Where? :)

@filrak
Copy link
Collaborator

filrak commented Feb 11, 2019

@filrak
Copy link
Collaborator

filrak commented Feb 11, 2019

@pkarw
Copy link
Collaborator Author

pkarw commented Feb 11, 2019

This is private, I can not use it from other modules / outside world to check which modules have been registered already. That was my point: I wanted to check in payment-backend-methods if the payment-cash-on-delivery has been registered and there was no way to do so. Still I don't see a way to do so :)

@pkarw pkarw reopened this Feb 11, 2019
@filrak
Copy link
Collaborator

filrak commented Feb 12, 2019

You're right. It was meant for internal use to avoid dependencys over modules but it can easly be moved outside and exported.

Will do it along with factory method refactor ok?

@pkarw
Copy link
Collaborator Author

pkarw commented Feb 12, 2019

Perfect!

@filrak filrak mentioned this issue Feb 13, 2019
3 tasks
@filrak filrak closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can
Projects
None yet
Development

No branches or pull requests

2 participants