-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module factory #2434
Module factory #2434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, however, it still requires some additional work to refactor all modules we have in the core, correct?
yup |
…ront into module_factory
ok just docs to be updated. @patzick you can review the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks cool generally.
To go further we need upgrade notes and changelog also :)
Co-Authored-By: filrak <f.rakowskI@hotmail.com>
…ront into module_factory
@patzick changelog and uprgade notes ready ;) |
Related issues
closes #2418
closes #2406
TODO:
I also made a minor refactor of
module.ts
and splitted the types out of it