Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjustment width of box for options in Erin Recommends #2458

Closed
ibugaj opened this issue Feb 19, 2019 · 2 comments
Closed

adjustment width of box for options in Erin Recommends #2458

ibugaj opened this issue Feb 19, 2019 · 2 comments
Assignees
@patzick
Labels
P3: Normal Priority mark - normal priority QA approved on branch Testers will add this label after positive check on specific branch.
Milestone
1.8.3

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 19, 2019

Current behavior

I suggest to change width of box with word "No" on the same like for "Yes" in section Erin Recommends on Filters.
In me feeling, it isn't look good with this difference, see:
image

Expected behavior

Better look for Erin Recommends section

Steps to reproduce the issue

  1. Open any PLP page
  2. See on Filters

Environment details

https://test.storefrontcloud.io
@pkarw
Copy link
Collaborator

pkarw commented Feb 22, 2019

I think that we should rather display these type of "Tag-a-like" filters without the line break. The options are text so we never know the width that fits all the options. But keeping them one after another we'll get better looking effect for sure

@pkarw pkarw added the P3: Normal Priority mark - normal priority label Feb 25, 2019
@patzick patzick assigned patzick and unassigned filrak Mar 1, 2019
@patzick patzick added this to the 1.8.3 milestone Mar 1, 2019
@patzick patzick mentioned this issue Mar 3, 2019
Merged
2 tasks
patzick added a commit to patzick/vue-storefront that referenced this issue Mar 3, 2019
@patzick
Merge branch 'develop' into feature/vuestorefront#2458-filters-adjust…
2600906 
…ment
patzick added a commit to patzick/vue-storefront that referenced this issue Mar 3, 2019
@patzick
Merge branch 'develop' into feature/vuestorefront#2458-filters-adjust…
f206ea1 
…ment
@patzick patzick mentioned this issue Mar 3, 2019
Merged
4 tasks
@patzick
Copy link
Collaborator

patzick commented Mar 3, 2019

with this issue there are there are two more UI improvements to test:

  1. To large quantity input on mobile view
    image

  2. bad margin on product tile with smaller resolutions
    image

this is resolved in second PR - #2531

patzick added a commit to patzick/vue-storefront that referenced this issue Mar 3, 2019
@patzick
Merge branch 'develop' into feature/vuestorefront#2458-filters-adjust…
50e5518 
…ment
patzick added a commit that referenced this issue Mar 3, 2019
@patzick
Merge pull request #2530 from patzick/feature/#2458-filters-adjustment
9cec3dc 
Feature/#2458 filters adjustment
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Mar 3, 2019
@patzick patzick closed this as completed Mar 3, 2019
@ArturDivante ArturDivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patzick patzick

Labels
P3: Normal Priority mark - normal priority QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Milestone
1.8.3
Development

No branches or pull requests
5 participants
@pkarw @patzick @filrak @ibugaj @ArturDivante