Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing page causes that images blinking for moment on other ones #2523

Closed
ibugaj opened this issue Mar 1, 2019 · 7 comments
Closed

Refreshing page causes that images blinking for moment on other ones #2523

ibugaj opened this issue Mar 1, 2019 · 7 comments
Assignees
Labels
P0: Critical Priority mark - highest one QA approved on branch Testers will add this label after positive check on specific branch.
Milestone

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Mar 1, 2019

Current behavior

Refreshing page causes that images blinking for moment on other ones

Expected behavior

Images shouldn't blinking on other when user refresh page

Steps to reproduce the issue

  1. Open any category of products
  2. Refresh page

Environment details

https://test.storefrontcloud.io

@ibugaj
Copy link
Collaborator Author

ibugaj commented Mar 1, 2019

blinking

@pkarw pkarw added the P0: Critical Priority mark - highest one label Mar 1, 2019
@pkarw
Copy link
Collaborator

pkarw commented Mar 1, 2019

Looks like CSR product/list returns different products or just in different order. BUT: when products has been queried in the SSR there should be no additional cal CSR

We must check it to make sure about the reason of this strange vehavior

@pkarw
Copy link
Collaborator

pkarw commented Mar 1, 2019

By some reason the CSR query is being executed: https://www.dropbox.com/s/pof6h2gtamzoy64/Screenshot%202019-03-01%2020.47.20.png?dl=0

@pkarw
Copy link
Collaborator

pkarw commented Mar 1, 2019

This issue doesn't exist in the 1.8.0 (on demo)

@pkarw
Copy link
Collaborator

pkarw commented Mar 1, 2019

Moreover, it's executed twice in the CSR by some reason :https://www.dropbox.com/s/ltdc1307ec0n6yr/Screenshot%202019-03-01%2020.57.57.png?dl=0

@pkarw
Copy link
Collaborator

pkarw commented Mar 1, 2019

@pkarw
Copy link
Collaborator

pkarw commented Mar 1, 2019

@patzick -> I belive that You should add the if (this.hasActiveFilters) { condition to resetAllFilters - because after SSR there are no active filters (this is only true before we merge in #2180 - but I think that with #2180 resetAllFilters no longer will be needed)

Please do test it and fix if this is good idea

@pkarw pkarw mentioned this issue Mar 1, 2019
@patzick patzick added this to the 1.8.3 milestone Mar 3, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Mar 3, 2019
@patzick patzick closed this as completed Mar 3, 2019
patzick added a commit that referenced this issue Mar 3, 2019
@ArturDivante ArturDivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: Critical Priority mark - highest one QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

No branches or pull requests

4 participants