Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-configurable products shouldn't have had childSku in the url #2605

Closed
pkarw opened this issue Mar 19, 2019 · 0 comments
Closed

Non-configurable products shouldn't have had childSku in the url #2605

pkarw opened this issue Mar 19, 2019 · 0 comments
Assignees
@Aekal
Labels
1: Easy bug Bug reports P3: Normal Priority mark - normal priority
Milestone
1.9.0-rc.2

Comments

@pkarw
Copy link
Collaborator

pkarw commented Mar 19, 2019

Current behavior

Currently, all the product links have childSku added to the link: https://next.storefrontcloud.io/training/training-9/luma-yoga-for-life-51.html?childSku

Even when it's empty.

Expected behavior

The childSku parameter is required only for configurable products.

1.9rc-1
@pkarw pkarw added bug Bug reports P1: Urgent Priority mark - high priority 1: Easy P3: Normal Priority mark - normal priority and removed P1: Urgent Priority mark - high priority labels Mar 19, 2019
@pkarw pkarw added this to the 1.9.0 milestone Mar 20, 2019
@Aekal Aekal self-assigned this Mar 21, 2019
Aekal added a commit to Aekal/vue-storefront that referenced this issue Mar 21, 2019
@Aekal
vuestorefront#2605 - Routes formatting
cc4f6cb
Aekal added a commit to Aekal/vue-storefront that referenced this issue Mar 21, 2019
@Aekal
vuestorefront#2605 - Remove childSku from url for not configurable pr…
d71584d 
…oducts
@Aekal Aekal mentioned this issue Mar 21, 2019
Closed
5 tasks
Aekal added a commit to Aekal/vue-storefront that referenced this issue Mar 21, 2019
@Aekal
vuestorefront#2605 - Update changelog
9970206
@patzick patzick modified the milestones: 1.9.0, 1.9.0-rc.2 Mar 21, 2019
Aekal added a commit to Aekal/vue-storefront that referenced this issue Mar 21, 2019
@Aekal
vuestorefront#2605 - Remove childSku from url for not configurable pr…
c5a52f4 
…oducts
@Aekal Aekal mentioned this issue Mar 21, 2019
Merged
5 tasks
pkarw added a commit that referenced this issue Mar 22, 2019
@pkarw
Merge pull request #2634 from Aekal/bugfix/2605
e7ea695 
#2605 - Remove childSku parameter in url for non-configurable products
@pkarw pkarw closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aekal Aekal

Labels
1: Easy bug Bug reports P3: Normal Priority mark - normal priority
Projects
None yet
Milestone
1.9.0-rc.2
Development

No branches or pull requests
3 participants
@pkarw @Aekal @patzick