Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force sorted translations #2657

Closed
2 of 5 tasks
lukeromanowicz opened this issue Mar 25, 2019 · 5 comments
Closed
2 of 5 tasks

Force sorted translations #2657

lukeromanowicz opened this issue Mar 25, 2019 · 5 comments
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront P4: Nice to have Priority mark - it's nice to have
Milestone

Comments

@lukeromanowicz
Copy link
Contributor

What is the motivation for adding / enhancing this feature?

I suggest sorting alphabetically currently existing translations + check if they are sorted correctly in CI.

It will be easier to find which messages have missing translations and what are the new translations comparing to a previous version.

What are the acceptance criteria

  • sort all translations with sort command (you can combine it with find to automatically do it for you)
  • add checking in CI if all translations are sorted using command from the point above combined with sort -c (FILE) (it returns 0 if all is sorted or 1 if there are disorders).

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.
@lukeromanowicz lukeromanowicz changed the title Force sorted translations in Vue Storefront Force sorted translations Mar 25, 2019
@lukeromanowicz lukeromanowicz added good first issue Tasks that requires just basic understanding of Vue Storefront P4: Nice to have Priority mark - it's nice to have 1: Easy labels Mar 25, 2019
@lukeromanowicz
Copy link
Contributor Author

What do you guys think @pkarw @patzick @filrak ?

@patzick
Copy link
Collaborator

patzick commented Mar 25, 2019

most of translations are theme specific - i'd move them there and leave only core needed translations.

@lukeromanowicz
Copy link
Contributor Author

@patzick yes, that's another issue to take care of. Do we want to do so in this issue or separate it?

@pkarw pkarw added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Mar 30, 2019
@filrak
Copy link
Collaborator

filrak commented Jun 18, 2019

@lukeromanowicz do you still want to take care of this?

@lukeromanowicz
Copy link
Contributor Author

@filrak I've been very busy recently. If you would like to take it, please, go ahead.

@lukeromanowicz lukeromanowicz added this to the 1.11.0 milestone Sep 4, 2019
@sandermangel sandermangel added this to Accepted Feature Requests in Issue Kanban Sep 6, 2019
patzick added a commit that referenced this issue Sep 10, 2019
@patzick patzick modified the milestones: 1.11.0, 1.11.0-rc.1 Sep 10, 2019
@patzick patzick closed this as completed Sep 10, 2019
Issue Kanban automation moved this from Accepted Feature Requests to Done Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront P4: Nice to have Priority mark - it's nice to have
Projects
No open projects
Issue Kanban
  
Done
Development

No branches or pull requests

4 participants