Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping methods not refreshed after country change in checkout #2691

Closed
2 of 5 tasks
tniezg opened this issue Apr 8, 2019 · 2 comments
Closed
2 of 5 tasks

Shipping methods not refreshed after country change in checkout #2691

tniezg opened this issue Apr 8, 2019 · 2 comments
Assignees
Labels
1: Easy bug Bug reports P1: Urgent Priority mark - high priority
Milestone

Comments

@tniezg
Copy link

tniezg commented Apr 8, 2019

Current behavior

Shipping methods don't update in checkout whenever the shipping country is changed.

Expected behavior

Update shipping informaiton and download current shipping methods when the country is changed.

Steps to reproduce the issue

  • Add products to cart
  • Go to checkout
  • Go to Shipping step
  • Change country

Result: Shipping methods under the Shipping form stay the same. @change prop isn't used to call changeCountry inside Shipping.ts.

Repository

Occurs in stock VS, default theme.

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Google Chrome Version 73.0.3683.86 (Official Build) (64-bit)
  • OS: macOS 10.14.3
  • Node: 8.15.0
  • Code Version: Up to this commit 215aa17

Additional information

Proposed fix: Based on https://vuejs.org/v2/guide/components-custom-events.html add a model key inside BaseSelect which remaps v-bind to emit change event instead of the default event (input) and $emit change instead of input.

Where to make the change: https://github.com/DivanteLtd/vue-storefront/blob/master/src/themes/default/components/core/blocks/Form/BaseSelect.vue#L33

@tniezg tniezg added the bug Bug reports label Apr 8, 2019
@revlis-x
Copy link

revlis-x commented Apr 8, 2019

Using @change.native works.

@pkarw pkarw added the 1: Easy label Apr 9, 2019
@pkarw pkarw added the P1: Urgent Priority mark - high priority label Apr 9, 2019
@pkarw pkarw added this to the 1.9.0 milestone Apr 10, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 12, 2019

@revlis-x - thanks for You insight! Could You please prepare a Pull Request with a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports P1: Urgent Priority mark - high priority
Projects
None yet
Development

No branches or pull requests

4 participants