Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture doesn't change when switching between the product's color variants #2709

Closed
2 of 4 tasks
GabiDivante opened this issue Apr 11, 2019 · 5 comments
Closed
2 of 4 tasks
Assignees
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Milestone

Comments

@GabiDivante
Copy link
Collaborator

Current behavior

Browsing the color versions does not change the image of the product.

Expected behavior

Browsing the color versions changes the picture of the product (selected color version is shown in the picture).

Steps to reproduce the issue

  1. Go to https://test.storefrontcloud.io/
  2. Click on category link Office casual
  3. Go to any product page
  4. Click on any other product colour version

Can you handle fixing this bug by yourself?

  • NO

Which Release Cycle state this refers to? Info for developer.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome
  • OS: Windows 10
@GabiDivante GabiDivante added the bug Bug reports label Apr 11, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 11, 2019

I can confirm the issue on test (however it apparently doesn't exist on next and demo instances):
Screenshot 2019-04-11 20 06 57

Maybe we should start with restoring the most recent database dump first

@pkarw pkarw added 3: Medium complexity P3: Normal Priority mark - normal priority vs-hackathon Tasks for the Hackathon labels Apr 11, 2019
pkarw added a commit that referenced this issue Apr 13, 2019
@pkarw pkarw mentioned this issue Apr 13, 2019
5 tasks
@pkarw pkarw closed this as completed Apr 13, 2019
patzick added a commit that referenced this issue Apr 14, 2019
@GabiDivante GabiDivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA approved on branch Testers will add this label after positive check on specific branch. labels Apr 23, 2019
@GabiDivante
Copy link
Collaborator Author

@pkarw there is still a problem with changing pictures for colors but only when you choose a different size than xs

@GabiDivante GabiDivante reopened this Apr 23, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 23, 2019

I belive it's not yet been deployed. Or maybe have You checked it locally?

@pkarw pkarw closed this as completed Apr 23, 2019
@GabiDivante
Copy link
Collaborator Author

@pkarw Yes, I checked it locally on branch bugfix/2709

@pkarw pkarw reopened this Apr 23, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 23, 2019

OK, it needs to be re-checked by @patzick then

@pkarw pkarw added this to the 1.10.0-rc.1 milestone Apr 23, 2019
patzick added a commit to patzick/vue-storefront that referenced this issue May 28, 2019
patzick added a commit to patzick/vue-storefront that referenced this issue May 28, 2019
pkarw added a commit that referenced this issue May 28, 2019
…ing-images

fix problem #2709, when variant not found we're searching for image w…
@pkarw pkarw closed this as completed May 28, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 29, 2019
@GabiDivante GabiDivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

3 participants