Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page: Header title displayed if newCollection product list not exists #2761

Closed
2 of 5 tasks
vishal-7037 opened this issue Apr 19, 2019 · 0 comments
Closed
2 of 5 tasks
Labels
1: Easy bug Bug reports P4: Nice to have Priority mark - it's nice to have

Comments

@vishal-7037
Copy link
Contributor

vishal-7037 commented Apr 19, 2019

Header title should be hidden if newCollection product list not exists
There are no products under Everything New section but the header is displayed. it shouldn't render id products are not available.

Current behavior

2019_04_18_Selection_001

Expected behavior

2019_04_18_Selection_002

Steps to reproduce the issue

  1. Removed products from Everything New Section
  2. Check only header is displayed

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome
  • OS: Ubuntu
  • Node: 10.15.1
  • Code Version:

Additional information

@vishal-7037 vishal-7037 added the bug Bug reports label Apr 19, 2019
@pkarw pkarw added 1: Easy P4: Nice to have Priority mark - it's nice to have labels Apr 23, 2019
@pkarw pkarw closed this as completed Apr 23, 2019
@pkarw pkarw mentioned this issue Apr 23, 2019
8 tasks
pkarw added a commit that referenced this issue Apr 23, 2019
@pkarw pkarw mentioned this issue Apr 23, 2019
8 tasks
pkarw added a commit that referenced this issue Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports P4: Nice to have Priority mark - it's nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants