Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do use the final_price for price display in Vue Storefront / Vue Storefront API #3099

Closed
1 of 7 tasks
pkarw opened this issue Jun 24, 2019 · 0 comments
Closed
1 of 7 tasks
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P2: Important Priority mark - still high ;)
Milestone

Comments

@pkarw
Copy link
Collaborator

pkarw commented Jun 24, 2019

What is the motivation for adding / enhancing this feature?

This is related to vuestorefront/magento2-vsbridge-indexer#71
We're taking the special_price as final in the tax.ts

Related to: #2918

What are the acceptance criteria

  • additional config option config.products.use_final_price (by default set to true)
  • final_price taken into consideration in tax.ts in vue-storefront-api + vue-storefront

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@pkarw pkarw added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Jun 24, 2019
@pkarw pkarw added this to the 1.11.0-rc.1 milestone Jun 24, 2019
@pkarw pkarw added P2: Important Priority mark - still high ;) 3: Medium complexity labels Jun 24, 2019
pkarw added a commit that referenced this issue Jun 28, 2019
@pkarw pkarw mentioned this issue Jun 28, 2019
8 tasks
@pkarw pkarw closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P2: Important Priority mark - still high ;)
Projects
None yet
Development

No branches or pull requests

1 participant