Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied discount code is lost when logging in / creating account / placing an order with account creation #3153

Closed
2 of 5 tasks
revlis-x opened this issue Jun 28, 2019 · 1 comment
Assignees
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority
Milestone

Comments

@revlis-x
Copy link

Current behavior

When a user logs in after applying a discount code ("mmtest") in the cart (e.g. log-in on checkout page), the discount code is no longer applied.
Moreover, if the user chooses to create an account during checkout, the order is placed without the applied discount code.

Expected behavior

Discount code is kept applied when user logs in or creates an account.

Steps to reproduce the issue

  1. Put item into cart and apply discount code "mmtest"
    2a. Create or log into existing account -> discount no longer applied
    2b. Create account during checkout -> order is placed without discount

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.
@revlis-x revlis-x added the bug Bug reports label Jun 28, 2019
@revlis-x revlis-x changed the title Applied discount code is lost when logging into / creating account Applied discount code is lost when logging into / creating account / placing an order with account creation Jun 28, 2019
@revlis-x revlis-x changed the title Applied discount code is lost when logging into / creating account / placing an order with account creation Applied discount code is lost when logging in / creating account / placing an order with account creation Jun 28, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jun 28, 2019

Good point! User authorization changes the shopping cartid (if user had the shopping cart assigned in magento) and in this case the discount code needs to be re-applied

@pkarw pkarw added 3: Medium complexity P3: Normal Priority mark - normal priority labels Jun 28, 2019
@pkarw pkarw added this to the 1.11.0-rc.1 milestone Jun 29, 2019
@andrzejewsky andrzejewsky self-assigned this Jul 19, 2019
@patzick patzick closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority
Projects
None yet
Development

No branches or pull requests

4 participants