Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Close' icon in the login popup is located in the wrong place. #3393

Closed
2 of 5 tasks
alinadivante opened this issue Aug 20, 2019 · 3 comments
Closed
2 of 5 tasks

'Close' icon in the login popup is located in the wrong place. #3393

alinadivante opened this issue Aug 20, 2019 · 3 comments
Assignees
Labels
bug Bug reports P3: Normal Priority mark - normal priority QA approved on branch Testers will add this label after positive check on specific branch.
Milestone

Comments

@alinadivante
Copy link
Collaborator

alinadivante commented Aug 20, 2019

Current behavior

'Close' icon in the login popup is located in the upper left corner.

image (1)

Expected behavior

'Close' icon should be located in the upper right corner.

Steps to reproduce the issue

  1. Go to https://test.storefrontcloud.io
  2. Press My account icon

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label Aug 20, 2019
@pkarw pkarw added the P3: Normal Priority mark - normal priority label Aug 20, 2019
@pkarw pkarw added this to the 1.11.0-rc.1 milestone Aug 20, 2019
@filrak
Copy link
Collaborator

filrak commented Aug 21, 2019

wasn't @andrzejewsky fixing this?

@andrzejewsky
Copy link
Contributor

andrzejewsky commented Aug 21, 2019

@filrak no 😄, but it looks so simple, I can do fix it in my other tasks as additional thing

pkarw added a commit that referenced this issue Aug 23, 2019
Moved login popup close icon to right
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Aug 23, 2019
@pkarw pkarw closed this as completed Aug 23, 2019
@alinadivante
Copy link
Collaborator Author

alinadivante commented Aug 23, 2019

@przspa just like we talked, please move X to the line
image

@alinadivante alinadivante added QA rejected Testers will add this label when something is still wrong and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Aug 23, 2019
@alinadivante alinadivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA rejected Testers will add this label when something is still wrong labels Aug 23, 2019
patzick added a commit that referenced this issue Aug 27, 2019
Fix body scroll lock and small visual changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports P3: Normal Priority mark - normal priority QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

No branches or pull requests

5 participants