Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo of the unavailable variant is displayed. #3436

Closed
1 of 5 tasks
alinadivante opened this issue Aug 27, 2019 · 1 comment
Closed
1 of 5 tasks

Photo of the unavailable variant is displayed. #3436

alinadivante opened this issue Aug 27, 2019 · 1 comment
Assignees
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Milestone

Comments

@alinadivante
Copy link
Collaborator

Relates to:

#3298

Current behavior

In the following configuration, where:
filterUnavailableVariants = true
configurableChildrenStockPrefetchStatic = true
configurableChildrenStockPrefetchDynamic = true

when I open a product with an unavailable option directly via the URL - then it's OK → unavailable variant is removed from the list. BUT when I open this product (with the unavailable variant) from the Home page or category page, then I see photo of the unavailable variant.

image

(after refreshing the page - variant disappears)

Expected behavior

Out-of-stock variant should not be displayed - in this case picture with unavailable color/size shouldn't be displayed.
Out-of-stock variants should be removed from the available variants list.

Steps to reproduce the issue

  1. Open vsf with the latest develop branch
  2. Click Gwyn Endurance Tee product (black blouse) from Everything new section on Home Page
  3. Try to add to cart default variant

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label Aug 27, 2019
@pkarw pkarw added P3: Normal Priority mark - normal priority 3: Medium complexity labels Aug 27, 2019
@pkarw pkarw added this to the 1.11.0-rc.1 milestone Aug 27, 2019
@pkarw pkarw added the vs-hackathon Tasks for the Hackathon label Aug 30, 2019
pkarw added a commit that referenced this issue Sep 4, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 4, 2019

@patzick please make sure we're supporting this feature in new product page as well: e24e10e

@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Sep 4, 2019
@pkarw pkarw closed this as completed Sep 4, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports P3: Normal Priority mark - normal priority QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

3 participants