Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for core/modules/recently-viewed #3467

Closed
3 tasks
pkarw opened this issue Sep 3, 2019 · 0 comments
Closed
3 tasks

Add unit tests for core/modules/recently-viewed #3467

pkarw opened this issue Sep 3, 2019 · 0 comments
Assignees
@gibkigonzo
Labels
1: Easy 3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can
Projects
Issue Kanban
Milestone
1.11.0-rc.1

Comments

@pkarw
Copy link
Collaborator

pkarw commented Sep 3, 2019

What is the motivation for adding/enhancing this feature?

Add unit tests for the module. Reference/example:

What are the acceptance criteria

  • all the actions should be tested
  • all the helpers should be tested
  • all the mutations should be tested
@pkarw pkarw added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can 1: Easy 3: Medium complexity labels Sep 3, 2019
@sandermangel sandermangel added this to Accepted Feature Requests in Issue Kanban Sep 6, 2019
@gibkigonzo gibkigonzo mentioned this issue Sep 11, 2019
Merged
6 tasks
patzick added a commit that referenced this issue Sep 12, 2019
@patzick
Merge pull request #3528 from gibkigonzo/feature/add-unit-tests-for-r…
06b80b0 
…ecently-viewed-module

add unit tests for recently viewed module #3467
@patzick patzick modified the milestones: 1.10.1, 1.11.0-rc.1 Sep 12, 2019
@patzick patzick closed this as completed Sep 12, 2019
Issue Kanban automation moved this from Accepted Feature Requests to Done Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibkigonzo gibkigonzo

Labels
1: Easy 3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can
Projects
No open projects
Issue Kanban
  
Done
Milestone
1.11.0-rc.1
Development

No branches or pull requests
3 participants
@pkarw @patzick @gibkigonzo