Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison feature is not keeping a state on page reload. #3508

Closed
vue-kacper opened this issue Sep 6, 2019 · 1 comment
Closed

Comparison feature is not keeping a state on page reload. #3508

vue-kacper opened this issue Sep 6, 2019 · 1 comment
Assignees
@vue-kacper
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P4: Nice to have Priority mark - it's nice to have
Projects
Issue Kanban
Milestone
1.11.0-rc.1

Comments

@vue-kacper
Copy link
Contributor

What is the motivation for adding / enhancing this feature?

A small unconvenience - products on comparison list are not preserved between page reloads. That means we can not compare one product with another opened in a new tab.

We should keep products in comparison list in a session. This will prevent resets on page reload. We will be also able to open new links in new tabs with preserved items.

What are the acceptance criteria

Page reload should not reset comparison list items.
@vue-kacper vue-kacper added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Sep 6, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 6, 2019

They should; they were; something is broken probably with https://github.com/DivanteLtd/vue-storefront/blob/68e7b62ae52c53158f4724e7fe31cbfaef533a25/core/modules/compare/store/plugin.ts#L9 - or reading this itetm from localStorage

@pkarw pkarw added the P4: Nice to have Priority mark - it's nice to have label Sep 6, 2019
@pkarw pkarw added this to the 1.11.0-rc.1 milestone Sep 6, 2019
@vue-kacper vue-kacper self-assigned this Sep 6, 2019
@vue-kacper vue-kacper mentioned this issue Sep 6, 2019
Merged
3 tasks
@sandermangel sandermangel added this to Confirmed Issues & Accepted features in Issue Kanban Sep 6, 2019
@pkarw pkarw closed this as completed Sep 10, 2019
Issue Kanban automation moved this from Accepted Feature Requests to Done Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vue-kacper vue-kacper

Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P4: Nice to have Priority mark - it's nice to have
Projects
No open projects
Issue Kanban
  
Done
Milestone
1.11.0-rc.1
Development

No branches or pull requests
2 participants
@pkarw @vue-kacper