Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3508 fixed comparison list preservation #3510

Merged
merged 3 commits into from
Sep 10, 2019
Merged

3508 fixed comparison list preservation #3510

merged 3 commits into from
Sep 10, 2019

Conversation

vue-kacper
Copy link
Contributor

closes #3508

Short description and why it's useful

Comparison list is now preserved between page refresh action

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, small change suggested

core/modules/compare/store/plugin.ts Outdated Show resolved Hide resolved
@vue-kacper vue-kacper added the vs-hackathon Tasks for the Hackathon label Sep 6, 2019
@patzick patzick requested a review from pkarw September 10, 2019 06:27
@pkarw pkarw merged commit 63e9c6b into vuestorefront:develop Sep 10, 2019
@patzick patzick added this to the 1.11.0-rc.1 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants